Update cmake build - #245
Merged
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Please find enclosed some modifications to the existing cmake build scripts. I am looking at this again because I've asked for re-flex to be packaged for Debian.
Changes:
libreflexmin.rtest.For Debian, its important the we include the AVX2/AVX-512BW capability even if the package-builder CPU doesn't support it, because the package will be installed on a different machine. Debian also can't build packages with
-march=native, since this would select the instruction set based on the build machine, not the installation machine.Of ./build.sh, autoconf, and cmake, the cmake scripts work best with Debian. I guess the autoconf scripts don't build shared libraries, only static? It seems like
./build.shkind of works, but modifying it sufficiently to put all the installed files in the right place and do all the other rigamarole would essentially be adding an additional build system. Whereas Debian can basically configure cmake to put everything in the right place to build a package.I have tested that these changes work on linux, linux-arm, mac-arm, windows, and linux->windows cross via github actions in the test-multi-arch PR.