Repository navigation
Conversation
Sanduhr32
reviewed
Mar 26, 2026
Sanduhr32
reviewed
Mar 26, 2026
Sanduhr32
reviewed
May 21, 2026
Sanduhr32
left a comment
There was a problem hiding this comment.
I don't wanna be the guy giving the green light, but it looks better than the initial state of the PR. Have you tested your changes?
RecursivePineapple
left a comment
There was a problem hiding this comment.
Looks good for the most part, one minor nitpick. The only blocker is the issue in the other PR.
Comment on lines
+256
to
+261
| if (ArchitectureCraftHelper.isLoaded() && ArchitectureCraftHelper.isShapeBlock( | ||
| schematicFlipped.getBlock(tileEntity.xCoord, tileEntity.yCoord, tileEntity.zCoord))) { | ||
| byte[] ori = ArchitectureCraftHelper.getOrientationFromTE(tileEntity); | ||
| byte[] newOri = ArchitectureCraftHelper.transformOrientationFlip(ori[0], ori[1], direction); | ||
| ArchitectureCraftHelper.setOrientationOnTE(tileEntity, newOri[0], newOri[1]); | ||
| } |
There was a problem hiding this comment.
All of these AC code blocks look identical, can we pull them out into a single method?
|
@RecursivePineapple do you want me to hijack this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to differentiate between different Architecturecraft block cuts, and orient them correctly during printing.
Depends on a separate update to Architecturecraft, which adds a
SetOrientationmessage for Schematica to use after placing the Architecturecraft block, in order to correct its orientation. The PR for the Architecturecraft update is here: GTNewHorizons/ArchitectureCraft#35Before/After:
