Vulkan test on linux. - #148
Open
takahiroharada wants to merge 2 commits into
Open
takahiroharada wants to merge 2 commits into
takahiroharada wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Vulkan/HIP external memory interoperability demo (
VulkanComputeSimple) and updates the build system to conditionally include the demo and its unit test only when Vulkan headers are available. The changes ensure that the demo is built and tested on both Windows and Linux, with robust handling for header dependencies.Key changes:
VulkanComputeSimple demo addition and documentation
VulkanComputeSimpledemo showcasing Vulkan/HIP external memory interop, including a comprehensiveREADME.adocwith build and usage instructions.Build system improvements for conditional demo inclusion
premake5.luaworkspace script to detect the presence of Vulkan headers (via Windows, LunarG SDK, or system headers) and set abuildVulkanDemoflag. The demo and its test are only included if this flag is set, with a clear message if skipped.VulkanComputeSimpledemo'spremake5.luato use system or SDK Vulkan headers on Linux, and to only add Windows-specific build options and links when building for Windows.UnitTest/premake5.lua) to defineORO_HAS_VULKAN_DEMOonly if the demo is being built, ensuring the test is conditionally compiled.Unit test conditional compilation
VulkanComputeSimple64unit test indemosTest.cppto depend on theORO_HAS_VULKAN_DEMOdefine, so the test is only present when the demo is built. [1] [2]