Skip to content

Fix regression test key and GWD/held-suarez regression cleanup - #1497

Merged
pchakraborty merged 4 commits into
release/MAPL-v3from
bugfix/pchakrab/setservices-regression-key
Aug 11, 2026
Merged

Fix regression test key and GWD/held-suarez regression cleanup#1497
pchakraborty merged 4 commits into
release/MAPL-v3from
bugfix/pchakrab/setservices-regression-key

Conversation

@pchakraborty

@pchakraborty pchakraborty commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Fix regression test key: setservice -> setservices
  • GWD regression: use copy_restarts() helper and enable expdir cleanup via file(REMOVE_RECURSE ...)
  • Held-Suarez regression: replace commented-out execute_process with file(REMOVE_RECURSE ...) for cleanup

Test plan

  • Regression tests pass for GWD and Held-Suarez cases

@pchakraborty
Fix regression test key: setservice -> setservices
f796ca4 
parse_child in MAPL's ComponentSpecParser previously matched a
truncated 'SetService' key due to a string-length bug (fixed in
GEOS-ESM/MAPL#5307). These regression yamls were written to match
that truncated key and need the trailing 's' restored now that the
parser correctly requires the full 'setservices' key.
@pchakraborty
Fix regression test key: setservice -> setservices
1ceb49e 
parse_child in MAPL's ComponentSpecParser previously matched a
truncated 'SetService' key due to a string-length bug (fixed in
GEOS-ESM/MAPL#5307). These regression yamls were written to match
that truncated key and need the trailing 's' restored now that the
parser correctly requires the full 'setservices' key.
@pchakraborty
fix(gwd/regression): use copy_restarts helper and enable expdir cleanup
e2f00fe
@pchakraborty
held-suarez regression: replace execute_process with file(REMOVE_RECU…
f7b7a91 
…RSE)
@pchakraborty
pchakraborty requested a review from a team as a code owner August 11, 2026 17:42
@pchakraborty pchakraborty self-assigned this Aug 11, 2026
@pchakraborty pchakraborty added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. MAPL3 MAPL 3 Related Skip Changelog labels Aug 11, 2026
@pchakraborty
pchakraborty merged commit 954d926 into release/MAPL-v3 Aug 11, 2026
17 of 19 checks passed
@pchakraborty
pchakraborty deleted the bugfix/pchakrab/setservices-regression-key branch August 11, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees

@pchakraborty pchakraborty

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. MAPL3 MAPL 3 Related Skip Changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pchakraborty @mathomp4