Minor bug fixes for make_bcs (init do_schmidt, fix dateline argument) - #1494
Open
weiyuan-jiang wants to merge 5 commits into
Open
Minor bug fixes for make_bcs (init do_schmidt, fix dateline argument)#1494weiyuan-jiang wants to merge 5 commits into
weiyuan-jiang wants to merge 5 commits into
Conversation
weiyuan-jiang
added
the
0 diff
Contributor
Author
|
This bug about dateline may only impacts the lat-lon TRIOL_OCEAN here |
gmao-rreichle
added
the
0 diff trivial
gmao-rreichle
changed the title
gmao-rreichle
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bugs in make bcs, see details below. Dateline bug fix has no impact on bcs for GMAO use cases (lat/long atm grid has not been used in a long time, and only DC lat/long was used).
Trivially 0-diff for running the GCM and GEOSldas.
Zero-diff for make_bcs. Tested by @biljanaorescanin on 10 August 2026.
GEOSgcm_GridComp/GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/makebcs/make_bcs_latlon.py
Line 46 in 899cb83
The
-bargument for mkCatchParam() was documented here