Fix regression test setservices key and re-enable expdir cleanup - #414
Merged
pchakraborty merged 3 commits intoAug 10, 2026
Merged
Conversation
parse_child in MAPL's ComponentSpecParser previously matched a truncated 'SetService' key due to a string-length bug (fixed in GEOS-ESM/MAPL#5307). These regression yamls were written to match that truncated key and need the trailing 's' restored now that the parser correctly requires the full 'setservices' key.
Uncomments the rm -rf of the experiment directory in run_case(), which had been disabled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
tclune
approved these changes
Aug 10, 2026
pchakraborty
added
0 diff trivial
mathomp4
reviewed
Aug 10, 2026
| # COMMAND ${CMAKE_COMMAND} -E rm -rf ${expdir} | ||
| # ) | ||
| execute_process( | ||
| COMMAND ${CMAKE_COMMAND} -E rm -rf ${expdir} |
Member
There was a problem hiding this comment.
Eeeeeeee. Scary. You might want to go with file(REMOVE_RECURSE). That's probably safer.
Collaborator
Author
There was a problem hiding this comment.
Oh! I'll update my run_case files
2 tasks
pchakraborty
added a commit
that referenced
this pull request
Aug 11, 2026
…ervice key (#415) * run_case.cmake: replace execute_process(rm -rf) with file(REMOVE_RECURSE) Use CMake's native recursive-remove command instead of shelling out to rm -rf via execute_process. * adv-dyn: drop the now-redundant setservice (singular) key #414 added setservices (plural) as the correct key alongside the old truncated setservice key for backward compatibility while the parser fix rolled out. Only setservices is needed now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setservice->setservicesin the adv-dyn/dyn-sa regression yamls, matching MAPL'sComponentSpecParsernow that Fix truncated length for 'SetServices' key in parse_child MAPL#5307 fixed a string-length bug that previously truncated the key.setservice) and new (setservices) key for backward compatibility.rm -rfcleanup of the experiment directory inrun_case()after regression comparison, which had been left disabled.Test plan