New shared module for functions used in both DynCore and AdvCore - #413
New shared module for functions used in both DynCore and AdvCore#413lizziel wants to merge 3 commits into
Conversation
This enables not building DynCore in models that only use AdvCore Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
20df9e5 to
1e11d2f
Compare
pchakraborty
added
0 diff
pchakraborty
left a comment
pchakraborty
left a comment
There was a problem hiding this comment.
Looks good to me, but we will need the CI to run first. I have triggered the CI tests, and will check back later to see if they passed.
pchakraborty
left a comment
pchakraborty
left a comment
There was a problem hiding this comment.
Our general convention is to make everything private by default and explicitly mark the routines as public
New additions to the file will not be private unless explicitly declared as public Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
|
@pchakraborty, I pushed the update to declare private by default, and public for the existing functions. Heads up this convention needs to be applied to several other existing files in the repo. |
|
@lizziel Can you maybe make a trivial commit somewhere and re-push. CircleCI wasn't set up to handle forks. I think I toggled something to allow it, but I can't figure out how to have it see your branch. I'm hoping a trivial commit like, I dunno, turning |
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
|
Okay, I pushed some no diff changes. They go a bit off-topic of the PR, by declaring access in existing files |
|
Yay. CircleCI ran. I forgot I need to approve the GitHub Actions. Weirdly, I can't figure out how to do the same with CircleCI. |
3 participants
This update moves the functions defined in DynCore but used in both DynCore and AdvCore to a new file. This allows skipping the build of DynCore and some of its dependencies in GCHP, which only uses AdvCore. I also added access declarations to jw and sw fortran files, and generally cleaned up the formatting in those files.