[BUGFIX] Don't carry over Camera Editor preview state when loading new chart#7629
Open
VICK-sys wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
status: pending triage
NotHyper-474
added
topic: camera editor
Hundrec
changed the title
4 tasks
Hundrec
force-pushed
the
preview/camera-editor
branch
from
d1db30b to
fa91b36
Compare
Contributor
|
This PR needs a rebase again! |
NotHyper-474
added
status: needs revision
Hundrec
force-pushed
the
preview/camera-editor
branch
3 times, most recently
from
9272b54 to
07e54aa
Compare
VICK-sys
force-pushed
the
fix/camera-editor-preview-state-carryover
branch
from
b7a2af0 to
7dfd534
Compare
NotHyper-474
added
status: pending triage
Hundrec
added
status: reviewing internally
Hundrec
changed the title
Hundrec
added
status: pending triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #7490
Description
CameraEditorState.buildStage()never cancelledcameraRect's in-flight tweens when loading a new chart. The stage's default zoom/scroll gets reassigned, but the next frame'supdate()lerpszoomback from the previous chart's still-activecameraZoomEase(and same forcameraFollowEase, which is why the camera position also fails to update). CallingcameraRect.cancelAllTweens()before reapplying zoom and scroll position makes the new chart's defaults stick.Screenshots/Videos
Demo.mp4