Repository navigation
Pin proteus-mpl 1.5.0 and make the validation plots again - #36
Merged
Merged
Conversation
Install proteus-mpl from the tl/validation-ci commit, which renders the validation plot on every run and compares its data summary with the committed pair. The pair is made again so that it carries the summary. A session hook prints each rendered summary as a warning, so the log holds the full summary of each Python version for a comparison with the committed one. This branch is a trial and is not meant for main.
Install proteus-mpl from the tl/validation-ci commit with the summary format 1 and make the pairs again. This branch is a trial and is not meant for main.
Install proteus-mpl from the newest tl/validation-ci commit and make the pairs again. This branch is a trial and is not meant for main.
Install proteus-mpl from the newest tl/validation-ci commit and make the pairs again. This branch is a trial and is not meant for main.
Install proteus-mpl from the newest tl/validation-ci commit and make the pairs again. This branch is a trial and is not meant for main.
proteus-mpl 1.5.0 compares the data summary of each validation plot with the committed pair in every test run, so the pair is made again with 1.5.0 and now carries the summary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin proteus-mpl 1.5.0, whose
validation_plotfixture compares each validation plot with a data summary stored in the committed files in every test run (FormingWorlds/proteus-visual-language#25). The pin moves toproteus-mpl>=1.5.0inpyproject.toml, anddocs/assets/validation/toa_flux_diluted_stellar_spectrum.svgand its dark copy (52541 B each) are made again with 1.5.0, so each now carries the summary the fixture compares against.Validation of changes
CI runs
pytest tests/with no marker filter, so the plot test is in the 100 tests that pass in each job, with no summary warning in the log. CI on the branch, Linux, Python 3.11 to 3.13, with proteus-mpl 1.5.0 installed: https://github.com/FormingWorlds/VULCAN/actions/runs/40087791833. Each committed file carries a summary of format 1 (read withproteus_mpl.validation.read_summary), and every file is under the 60 000 B cap.Checklist
Relevant people