Skip to content

Pin proteus-mpl 1.5.0 and make the validation plots again - #36

Merged
timlichtenberg merged 7 commits into
mainfrom
tl/validation-ci-pilot
Oct 24, 2026
Merged

timlichtenberg merged 7 commits into
mainfrom
tl/validation-ci-pilot

Conversation

@timlichtenberg

Copy link
Copy Markdown
Member

Description

Pin proteus-mpl 1.5.0, whose validation_plot fixture compares each validation plot with a data summary stored in the committed files in every test run (FormingWorlds/proteus-visual-language#25). The pin moves to proteus-mpl>=1.5.0 in pyproject.toml, and docs/assets/validation/toa_flux_diluted_stellar_spectrum.svg and its dark copy (52541 B each) are made again with 1.5.0, so each now carries the summary the fixture compares against.

Validation of changes

CI runs pytest tests/ with no marker filter, so the plot test is in the 100 tests that pass in each job, with no summary warning in the log. CI on the branch, Linux, Python 3.11 to 3.13, with proteus-mpl 1.5.0 installed: https://github.com/FormingWorlds/VULCAN/actions/runs/40087791833. Each committed file carries a summary of format 1 (read with proteus_mpl.validation.read_summary), and every file is under the 60 000 B cap.

Checklist

  • I have followed the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have checked that the tests still pass on my computer
  • I have updated the docs, as appropriate
  • I have added tests for these changes, as appropriate
  • I have checked that all dependencies have been updated, as required

Relevant people

Install proteus-mpl from the tl/validation-ci commit, which renders the validation plot on every run and compares its data summary with the committed pair. The pair is made again so that it carries the summary. A session hook prints each rendered summary as a warning, so the log holds the full summary of each Python version for a comparison with the committed one. This branch is a trial and is not meant for main.
Install proteus-mpl from the tl/validation-ci commit with the summary format 1 and make the pairs again. This branch is a trial and is not meant for main.
Install proteus-mpl from the newest tl/validation-ci commit and make the pairs again. This branch is a trial and is not meant for main.
Install proteus-mpl from the newest tl/validation-ci commit and make the pairs again. This branch is a trial and is not meant for main.
Install proteus-mpl from the newest tl/validation-ci commit and make the pairs again. This branch is a trial and is not meant for main.
proteus-mpl 1.5.0 compares the data summary of each validation plot with the committed pair in every test run, so the pair is made again with 1.5.0 and now carries the summary.
@timlichtenberg
timlichtenberg merged commit a7e00f5 into main Oct 24, 2026
7 of 10 checks passed
@timlichtenberg
timlichtenberg deleted the tl/validation-ci-pilot branch October 24, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant