Conversation
Hecklezz
requested changes
Sep 21, 2026
TlNKER
force-pushed
the
fire-36987-cloud-color-chooser
branch
from
September 21, 2026 18:08
a89b402 to
de751ec
Compare
Author
|
Whoops! clear oversight from my end, since I run pink default. Should be fixed now, so both Preferences float shows Red as default selected as well as the actual clouds are the usual red tones defined in cloud.xml until and if the user changes that. |
Hecklezz
approved these changes
Sep 21, 2026
Ansariel
reviewed
Sep 21, 2026
| // (LLControlVariable* control, const LLSD& new_value, const LLSD& old_value); | ||
| // the new_value itself isn't used since both colors need re-reading either | ||
| // way, so just re-apply from gSavedSettings directly. | ||
| static void onCloudColorChanged(const LLSD& new_value) |
Collaborator
There was a problem hiding this comment.
Why do we need this extra function? new_value is never used, so you can just bind directly to LLVOAvatar::applyCloudColor() instead.
| // the user changes either preference later (no restart needed - see | ||
| // applyCloudColor()). | ||
| applyCloudColor(); | ||
| gSavedSettings.getControl("FSCloudColorStart")->getSignal()->connect( |
Collaborator
There was a problem hiding this comment.
Should probably store the signal connection and disconnect before if connected, especially since there is a menu option to reload the particle cloud, so you will end up calling onCloudColorChanged multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes my ticket on jira: https://jira.firestormviewer.org/browse/FIRE-36987
Summary
Adds two new preferences so the colour of the avatar loading/bakefail "cloud" particle effect can be customized, instead of it being a fixed color. Exposed as two color pickers under Preferences > Firestorm > Extras.
Details
Testing