Conversation
TlNKER
force-pushed
the
fire-34881-library-toggle
branch
from
September 15, 2026 11:04
4ac7ed6 to
948a721
Compare
… so it actually appears
TlNKER
force-pushed
the
fire-34881-library-toggle
branch
from
September 15, 2026 11:06
948a721 to
496ce60
Compare
Contributor
|
All looks good, however this also hides the Library folder from the texture picker when editing objects, the load sky and water picker in the day/night cycle floater, and the my environments floater under Top Menu->World->Environments->My Environments Is this intentional of this new toggle, or isn't? |
Author
|
That is by design. I figured black/white would work best. Either you have it or you don't. (obviously without impacting or effecting viewer performance, so the viewer can still call on the elements in the Library, but it wont show to the user). |
Hecklezz
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes important part* of FIRE-34881: https://jira.firestormviewer.org/browse/FIRE-34881
Allows user to go into cog wheel > Tabs & Views > Show Library. This toggles whether Library shows in the inventory floater or not. The underpinning objects are still fully accessible to the system, only hidden from the user's view, confirmed that objects from Library still works (Avatar > Avatar Welcome Pack... and all aspects of LSL Bridge works with the Library hidden).
FSShowLibraryFolder(default: shown), persisted per-userLLInventoryPanel::setLibraryFolderVisible()builds or tears down just the Library root's folder view live, without a restart. The underlying inventory model/data for Library is untouched either way, since other systems (default attachments, outfit lookups, etc.) depend on being able to resolve the Library folder ID regardless of whether its view is shown.arrangeAll()to actually become visible (LLFolderViewFolder::addFolder()has its ownrequestArrange()call commented out), matching the existing pattern used inopenAllFolders()/closeAllFolders()/setSorter().Inventory.GearDefault.Custom.Action/Checkcallbacks.All changes are tagged
<FS:TP>per CONTRIBUTING.md, with the original code preserved as comments where replaced as instructed.(I've decided that was the important part as I was the one raising the ticket to begin with :p)