Enable @typescript-eslint/prefer-includes - #302
Merged
Conversation
One violation, auto-fixed: a bare-literal regex test in http.unit.test.ts becomes a String#includes call with identical semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ryanhugh
enabled auto-merge (squash)
August 13, 2026 17:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
"@typescript-eslint/prefer-includes": "error"to the type-aware rules block ofeslint.config.mjs.Violations: 1, auto-fixed.
The fix
scrapers/myChart/__tests__/http.unit.test.ts— the Sec-Ch-Ua brand filter:Behavior analysis: behavior-neutral.
Chromis a bare literal regex — no anchors, no metacharacters, no flags — so/Chrom/.test(s)ands.includes('Chrom')are the same substring test on every input. The rule also covers theindexOf(...) !== -1idiom repo-wide going forward.Verified:
npx eslint .clean,bun run typecheckclean,bun run test1514 pass / 0 fail.🤖 Generated with Claude Code