Repository navigation
Fix Windows stub generation in wheel builds - #4673
Merged
Merged
Conversation
Import basix in the stub-generation package so its vendored DLLs are found, install the DOLFINx runtime dependencies in the wheel build, and search the Basix wheel's .libs directory when resolving them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
garth-wells
approved these changes
Oct 24, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JSeaTpCGdwgs2q2zZ6CFK4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basixandmpi4pyin the fake stub-generation__init__.pyso its vendored DLLs are found. This is the same as in the real__init__.py.INSTALL_RUNTIME_DEPENDENCIES=ONin the wheel build, so the non-system DLLsdolfinx.dlldepends on (for example HDF5, pugixml, spdlog and fmt, plus the BLAS and LAPACK DLLs from Basix) are installed beside it. Before this PR, the installbinheld onlydolfinx.dlland importingdolfinx.cppfor stub generation failed. This does not replace thedelvewheelstep later on, which vendors and mangles the DLLs into the wheelsfenics_dolfinx.libsas before.fenics_basix.libsdirectory when resolving runtime dependencies.Depends on FEniCS/basix#1106 (merged).
Testing
build-wheels.yml(run 40306051852) with this branch and Basixmain: Windows wheel contains the.pyifiles,py.typedand vendored DLLs, and the wheel tests pass.🤖 Generated with Claude Code