Skip to content

fix: add explicit (const void*) cast to cudaLaunchCooperativeKernel i… - #2436

Closed
parejadan wants to merge 1 commit into
EricLBuehler:masterfrom
parejadan:fix-radix-topk-gcc13-compile
Closed

parejadan wants to merge 1 commit into
EricLBuehler:masterfrom
parejadan:fix-radix-topk-gcc13-compile

Conversation

@parejadan

Copy link
Copy Markdown

Description

Fixes a severe CUDA template deduction compilation panic on GCC 13+ (e.g. GCC 13/14). cudaLaunchCooperativeKernel expects a const void* for its first argument, but the templated kernel function pointer was being passed implicitly. This adds the explicit cast.

Fixes #2435

@github-actions

Copy link
Copy Markdown
Code Metrics Report
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 Language              Files        Lines         Code     Comments       Blanks
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 C Header                 46         9600         7138         1327         1135
 C++                       1           36           30            1            5
 C++ Header                6         4022         3237          399          386
 CSS                       5         1069          918            6          145
 CUDA                    143        38519        32957         1775         3787
 Dockerfile                1           35           19            9            7
 HTML                      3          125          119            0            6
 JavaScript                8         1241         1186           11           44
 Jinja2                    7          694          656            5           33
 JSON                     34        27568        27565            0            3
 Makefile                  1           18           16            0            2
 MDX                      37         6974            0         5156         1818
 Metal Shading Lan|       37        14422        11414         1136         1872
 PowerShell                1          657          571           31           55
 Python                  161        34938        31448          487         3003
 Shell                     3         1071          852          115          104
 Plain Text               54        10714            0         9231         1483
 TOML                     28         1399         1212           43          144
 TypeScript               11         1658         1418           66          174
 YAML                      3           25           23            2            0
─────────────────────────────────────────────────────────────────────────────────
 Jupyter Notebooks         3          122           83           23           16
 |- Markdown               1           60           30           22            8
 |- Python                 1          122          113            1            8
 (Total)                              304          226           46           32
─────────────────────────────────────────────────────────────────────────────────
 Markdown                283        13044            0         9784         3260
 |- BASH                  27          349          268           48           33
 |- Dockerfile             2           14           12            0            2
 |- JSON                   6          292          292            0            0
 |- PowerShell             1            1            1            0            0
 |- Python               135         7349         6119          306          924
 |- Rust                  63         3873         2873          398          602
 |- TOML                   7          116           97            0           19
 (Total)                            25038         9662        10536         4840
─────────────────────────────────────────────────────────────────────────────────
 Rust                    772       500427       456580         5582        38265
 |- Markdown             443        10396          452         8755         1189
 (Total)                           510823       457032        14337        39454
─────────────────────────────────────────────────────────────────────────────────
 Svelte                   19         1974         1832           50           92
 |- CSS                    1            4            4            0            0
 |- JavaScript            19          928          773           25          130
 (Total)                             2906         2609           75          222
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 Total                  1667       693856       590308        44794        58754
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

@parejadan parejadan closed this Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CUDA compilation fails on GCC 13+ (cudaLaunchCooperativeKernel template deduction error in radix_topk.cuh)

1 participant