Add fit flag to Parameter - #5
Merged
Merged
Conversation
Advanced the specs submodule pointer to commit bf9321f720eaff48d315bad52aebc1765cf42188 to incorporate recent changes from the submodule.
Adjusted the expected minimum duration from 100ms to 80ms in the fromName integration test to better reflect current performance.
Introduces a nullable boolean 'fit' property to ParameterSchema to indicate if a parameter should be varied during optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new field to the parameter schema, updates an integration test expectation, and updates a submodule reference. The most significant change is the addition of the
fitfield to the parameter schema, which enhances the model's ability to specify optimization behavior.Schema Enhancement:
fitto theParameterSchemainsrc/v2.ts, allowing parameters to indicate whether they should be varied during optimization.Testing Adjustment:
fromName Integration Testsfrom 100ms to 80ms to better reflect actual performance. (__tests__/pubchem.integration.test.ts)Submodule Update:
specsto point to a newer commit, ensuring dependencies are up-to-date.