Add a Prettier plugins input to the Prettier workflows - #232
Merged
Conversation
Prettier loads the plugins named by a project's configuration at startup, before it looks at any file, and resolves them from the checkout root. A repository whose .prettierrc declares a plugin such as prettier-plugin-astro fails every Prettier job with "Cannot find package", regardless of which file types that job formats, because these workflows run Prettier through npx without the plugin present. Add a prettier_plugins input to check-html.yml, check-markdown.yml, and the CHANGELOG formatting step in the three bump-version workflows. When set, the listed npm packages are installed alongside Prettier following the same pattern as check-css.yml, and the project's own configuration remains the source of truth for which plugins are active. The bump-version steps remove the installed node_modules afterward so it stays out of the release pull request. Callers that leave the input empty run the same npx command as before.
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier loads the plugins named by a project's configuration at startup, before it looks at any file, and resolves them from the checkout root. A repository whose .prettierrc declares a plugin such as prettier-plugin-astro fails every Prettier job with "Cannot find package", regardless of which file types that job formats, because these workflows run Prettier through npx without the plugin present.
Add a prettier_plugins input to check-html.yml, check-markdown.yml, and the CHANGELOG formatting step in the three bump-version workflows. When set, the listed npm packages are installed alongside Prettier following the same pattern as check-css.yml, and the project's own configuration remains the source of truth for which plugins are active. The bump-version steps remove the installed node_modules afterward so it stays out of the release pull request.
Callers that leave the input empty run the same npx command as before.