Feature/low effort fixes#106
Draft
omarmorshedy wants to merge 3 commits into
Draft
Conversation
The previous query used '.where('ends', '<=', end)' which only returned
bookings ending on or before the end date. This missed bookings that end
after the end date but still overlap the requested range.
Changed to '.where('ends', '>', start)' so all bookings ending after the
start of the requested range are returned. The overlap check in the
bookings route then correctly filters them.
… redirect The POST /admin/slots/create route was sending requests to /api/resource-types instead of /api/slots, and redirecting to /admin/resource-types instead of /admin/slots. Both have been corrected to match the intended functionality.
Moved the hardcoded session secret to an environment variable (OPTIMISM_SESSION_SECRET) with the previous value as a fallback. Hardcoded secrets in source code are a security risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.