Skip to content

LIMS-2151: Allow summary page to be for visits/proteins/groups#1075

Merged
ndg63276 merged 4 commits into
pre-release/2026-R3.2from
improvement/LIMS-2151/allow-summary-by-protein-or-samplegroup
Jun 16, 2026
Merged

LIMS-2151: Allow summary page to be for visits/proteins/groups#1075
ndg63276 merged 4 commits into
pre-release/2026-R3.2from
improvement/LIMS-2151/allow-summary-by-protein-or-samplegroup

Conversation

@ndg63276

@ndg63276 ndg63276 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-2151

Summary:

Use the same summary page to compare data processing from an entire protein, or from an entire sample group, as well as from an entire visit.

Changes:

  • Pass protein id or sample group id to the backend, check they belong to the proposal, add additional joins as needed to get the data
  • Use suitable csv filename for each
  • Always get proteins in the same order
  • Extend sample groups collection into a type that can generate a dropdown list
  • Add extra routes and triggers for visit/protein/group summary pages
  • Add dropdowns to the summary page to change between visit/protein/group, and to select which visit/protein/group to view
  • Add css to make the dropdowns look similar to the text
  • Add link to the summary page from the visit/protein/group list pages

To test:

  • Go to any proposal, then go to /visits, check any visit with data now has a 4th button marked View Summary, that takes you to /dc/summary/visit/. Check the first dropdown at the top says "Visit", and the second says the correct visit.
  • Go to /proteins, check each protein now has a 2nd button marked View Summary, that takes you to /dc/summary/protein/. Check the first dropdown at the top says "Protein", and the second says the correct acronym.
  • Go to /samples/groups/, check each group now has a 2nd button marked View Summary, that takes you to /dc/summary/group/. Check the first dropdown at the top says "Group", and the second says the correct group name.
  • Check you can change groups and the data updates (not all groups have data). Check the "View Sample Groups" and "Download CSV" buttons work.
  • Check you can change the type to Visit, and then select a visit, and the data updates. Check the "All Data Collections" and "Download CSV" buttons work.
  • Check you can change the type to Protein, and then select a protein, and the data updates. Check the "View Protein" and "Download CSV" buttons work.
  • Check the various filters (eg Min Completeness) and the search bar still work.

Comment thread client/src/js/templates/dc/summary.html Outdated
@gfrn

gfrn commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Null visits are still displayed on the dropdown, is that on purpose? All looks good otherwise

@ndg63276

Copy link
Copy Markdown
Collaborator Author

Null visits are still displayed on the dropdown, is that on purpose? All looks good otherwise

No, that was an accident, good spot. Should be fixed now.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2026-R3.2 June 16, 2026 09:17
@ndg63276 ndg63276 merged commit 7ef88ec into pre-release/2026-R3.2 Jun 16, 2026
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-2151/allow-summary-by-protein-or-samplegroup branch June 16, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants