only follow same-origin returnPath after login - #11958
Merged
bhollis merged 1 commit intoAug 18, 2026
Merged
Conversation
bhollis
approved these changes
Aug 18, 2026
Contributor
Author
|
TY! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleAuthReturn finishes the bungie login by pointing the browser at whatever path we stored in localStorage before login, but it never checks the value is one of our own paths. that stored value comes from the pre-login url, so visiting something like app.destinyitemmanager.com//evil.com leaves
//evil.comin returnPath, and once the user has authorised it gets treated as a protocol-relative url and quietly sends them off-site. this resolves the stored path against our own origin and only follows it when the origin matches, otherwise falling back to the public path, which also covers the backslash variants browsers normalise to//.