Repository navigation
docs(onprem): safer ddorch certificate handling in the Helm upgrade render - #16303
Merged
Merged
Conversation
…ender - Read the ddorch certificates back from the release's stored values in a private mktemp directory (umask 077), with a fallback to the chart's objects that works whether the private key is in the ConfigMap or the <fullname>-orch-certs Secret, and the ddorch.tls.existingSecret case. - Name the chart's objects and Secret by its full name, which depends on the release name, tenantPrefix and fullnameOverride. - Pull the chart only when upgrading from the registry, render into the private directory, and delete it afterwards. - Name cosign 2.x's flag for skipping the transparency log, drop an unverified version from the FIPS note, word the bootstrap note so it holds for either key location, and label the upgrade-procedure link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
blakeaowens
approved these changes
Oct 12, 2026
devGregA
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16301, from a review of the Helm upgrade and install pages it changed.
Fixed
/tmp.mktemp -d, withumask 077).helm get values -o jsonandjq. That works because values passed with--set-fileare kept in the release, which I checked against a test release.test -s.<fullname>-orch-certs-configmapConfigMap, or in a<fullname>-orch-certsSecret. It also coversddorch.tls.existingSecret, where the key is not copied at all. I tested both the values path and the fallback (ConfigMap and Secret layouts) against test releases.dojopro, otherwise<release>-dojopro, andtenantPrefixorfullnameOverridechange it. The upgrade step and the admin-password section now say so, and show how to list the exact names.$CHART, then ranhelm pullregardless. The pull is now only for the registry path.--insecure-ignore-tlog=truefor networks without internet access. I checked that flag against cosign's ownverify-blobreference for 2.0.0 and 2.4.1.Not changed: translated pages
The translated copies of these pages (de, es, fr, it, ja, pt-br, zh-hans) did not get the #16301 fixes and still carry the older commands. Under
docs/TRANSLATIONS.md, English is the source and translations are regenerated from it by the translation pipeline, so this PR does not edit them. The next translation refresh should pick up #16301 and this PR.Checks
npm run build -- --environment developmentandhugo --minify --gc --config config/production/hugo.tomlindocs/: both exit 0 with no warnings or errors.🤖 Generated with Claude Code