Add an optional desktop app launcher - #400
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This keeps TorBot CLI-first, but gives people a simple way to open the separate TorBotApp desktop UI when they have it installed locally. The app stays optional, so we are not pulling Node or Electron into the Python package.
The installed
torbotcommand now supports bothtorbot appandtorbot --app, with discovery through--app-dir,TORBOT_APP_DIR, or a siblingTorBotAppcheckout.I also moved the CLI implementation into the package so the console entry point works from an installed wheel, bumped the version to
4.2.0, removed the deprecatedsklearndependency, and made the publish script safer around current-version artifacts and PyPI tokens.Checks
.venv/bin/python -m pytest.venv/bin/python -m flake8 main.py src/torbot/cli.py src/torbot/modules/app_launcher.py tests/test_cli_and_crawler.pyscripts/publish.shtorbot-4.2.0wheel in a fresh temp venv and checkedtorbot --versionplus the app-launch guidance path