Skip to content

[pd].str.replace() fails if regex=True not specified - #11

Open
Stabledog wants to merge 1 commit into
DavidMertz:mainfrom
Stabledog:fix-broken-Exploring.ipynb
Open

Stabledog wants to merge 1 commit into
DavidMertz:mainfrom
Stabledog:fix-broken-Exploring.ipynb

Conversation

@Stabledog

@Stabledog Stabledog commented Aug 24, 2023 •

Copy link
Copy Markdown

See https://pandas.pydata.org/docs/reference/api/pandas.Series.str.replace.html -- discovered when working the Exploring.ipynb. Seems probably an API change to the Pandas .str.replace() default behavior?

Since the .replace() fails to have an affect on values like BA=, the subsequent .astype(int) raises exceptions on relevant values.

This change corrects the problem by forcing regex=True.

See https://pandas.pydata.org/docs/reference/api/pandas.Series.str.replace.html -- discovered when working the `Exploring.ipynb`.  Seems probably an API change to the Pandas `.str.replace()` default behavior?
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant