Conversation
Apply consistent lint and formatting checks to tracked shell scripts and Bats suites, both locally and in CI. Resolve the existing license-script findings so the checks start clean while preserving their failure statuses.
kakkoyun
marked this pull request as draft
September 18, 2026 08:38
kakkoyun
changed the title
github-actions
Bot
added
the
conventional-commit/chore
kakkoyun
marked this pull request as ready for review
September 18, 2026 08:46
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Standalone shell scripts have no repository-wide lint or formatting checks. Add the same checks for local development and CI.
Changes
make lint/shellandmake format/shell, and include them inmake lintandmake format..shand.batsfiles, excluding downloaded or generated tools.exit -1with its existing Bash status,255.Verification
ShellCheck, shfmt, Bash syntax, Makefile/workflow lint, and
go build ./...passed. All 14 regression cases from the coverage branch passed against the modified scripts, including temporary paths containing spaces. A failure-injection check confirmed the Makefile target propagates ShellCheck errors.Independent base:
main.