Skip to content

🐛 Tolerate an invalid view URL in the developer extension#4773

Open
sethfowler-datadog wants to merge 1 commit into
mainfrom
seth.fowler/tolerate-invalid-view-url-in-dev-extension
Open

🐛 Tolerate an invalid view URL in the developer extension#4773
sethfowler-datadog wants to merge 1 commit into
mainfrom
seth.fowler/tolerate-invalid-view-url-in-dev-extension

Conversation

@sethfowler-datadog

Copy link
Copy Markdown
Contributor

Motivation

If a customer uses beforeSend() to set view.url to a value which is not actually a URL, it can cause the developer extension to crash, which makes debugging quite difficult.

Changes

This PR catches the exception thrown in getViewName() from new URL(view.url) and applies a fallback view name.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@sethfowler-datadog sethfowler-datadog requested a review from a team as a code owner June 12, 2026 15:15
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 172.04 KiB 172.04 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.09 KiB 21.09 KiB 0 B 0.00%
Logs 54.64 KiB 54.64 KiB 0 B 0.00%
Rum Slim 129.72 KiB 129.72 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jun 12, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.83% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2c93fd5 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants