🐛 Tolerate an invalid view URL in the developer extension#4773
Open
sethfowler-datadog wants to merge 1 commit into
Open
🐛 Tolerate an invalid view URL in the developer extension#4773sethfowler-datadog wants to merge 1 commit into
sethfowler-datadog wants to merge 1 commit into
Conversation
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2c93fd5 | Docs | Datadog PR Page | Give us feedback! |
BeltranBulbarellaDD
approved these changes
Jun 12, 2026
BenoitZugmeyer
approved these changes
Jun 12, 2026
thomas-lebeau
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a customer uses
beforeSend()to setview.urlto a value which is not actually a URL, it can cause the developer extension to crash, which makes debugging quite difficult.Changes
This PR catches the exception thrown in
getViewName()fromnew URL(view.url)and applies a fallback view name.Checklist