⚗️ Track Server-Sent Events counts on RUM resources#4764
Draft
samcolmanetti wants to merge 1 commit into
Draft
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Bundles Sizes Evolution
|
|
6be3829 to
68a37e2
Compare
68a37e2 to
f856fe8
Compare
f856fe8 to
edb8637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A
text/event-streamfetch is opaque in RUM today: no visibility into how many events streamed, of which types, or when the stream went quiet. This adds a compactresource.sseobject to the resource event, behind thesse_event_countsexperimental flag. Wire-schema (rum-events-format) update is a tracked follow-up; ingestion already accepts the field.Note: There's also work underway to support WebSockets (design doc). There may be room to consolidate both into a generalized "event stream" abstraction down the line. The key difference: SSE already appears in RUM as a normal Resource (type: fetch) and only lacks this metadata, whereas I don't believe WebSocket connections show up as RUM resources today.
Changes
Test Plan
_other_, id truncation)typecheckandlintclean/ssedev endpoint yieldsresource.sse; SSE-triggered click closes without hitting the 10s max