Add pyFANS configuration via compile flags for multiple pybind11 modules#142
Open
Snapex2409 wants to merge 4 commits into
Open
Add pyFANS configuration via compile flags for multiple pybind11 modules#142Snapex2409 wants to merge 4 commits into
Snapex2409 wants to merge 4 commits into
Conversation
Snapex2409
force-pushed
the
pyfans-compile-flags
branch
from
May 7, 2026 08:47
ec53807 to
e51ee0a
Compare
# Conflicts: # pyfans/micro.cpp # pyfans/micro.hpp # Conflicts: # pyfans/micro.cpp # pyfans/micro.hpp
Snapex2409
force-pushed
the
pyfans-compile-flags
branch
from
July 16, 2026 09:16
e51ee0a to
7d3abb4
Compare
Snapex2409
marked this pull request as ready for review
July 16, 2026 09:22
IshaanDesai
self-requested a review
July 16, 2026 10:05
IshaanDesai
approved these changes
Jul 17, 2026
IshaanDesai
left a comment
IshaanDesai
left a comment
Collaborator
There was a problem hiding this comment.
The changes make sense, although I have not tested this. @Snapex2409, I assume you have tested this. I have one suggestion: let's add an example of how the CMake command would look, for 2 or 3 simultaneous pyFANS builds. Right now, the use is unclear. Let's make this explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, this addition was intended to configure only the pyFANS input file path at compile time.
However, when loading a compiled pyFANS object in Python, pybind11 prohibits loading another library object containing a class with the same module and class name. Therefore, further flags were introduced.
Now multiple versions of pyFANS can be loaded at the same time:
Checklist:
CHANGELOG.md.