mb/protectli/vault_jsl/spd/spd_16147960_NEW.hex: add - #766
Draft
filipleple wants to merge 916 commits into
Draft
Conversation
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
TXT SINIT ACM checks the PEG bridge memory ranges whether they are correctly assigned in the MMIO space. If the bridge is enabled but no device is attached to it, coreboot will not assign any resources (if hotplug is not enabled). When SINIT ACM checks the ranges, it fails on prefetchable range check. Hide the PEG devices if the bridge is not active. PCIe bridges should generally be hidden if hotplug is not enabled and there is no downstream device. Upstream-status: CB:87472 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Upstream-Status: Inappropriate (Dasharo downstream) Change-Id: Ic54ab3230362eafd3f002d0a45d7e44087c85393 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Upstream-Status: Inappropriate (Dasharo downstream) Change-Id: Ic62b4486c34c89dc1f69af9e2471a5bc3428e137 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Upstream-Status: Inappropriate (Dasharo automation) Change-Id: I7dbb2abe03cd51b263ebb25d9cf499b03e253d76 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
The USB-C port is Gen2x2 and occupies two USB3.x line pairs. The missing second pair caused all the ports to be shifted by one and port 10 not being enabled as USB3.x capable. As a result one of the JUSB3 ports was working in HighSpeed only. Also revise the USB OC mappings again and put correct OC pins to macros. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Upstream-Status: Pending Change-Id: Ie3aaa65b272f097c7fa0805dd254e8999a776561 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Without it, the script failed with cryptic error:
$ ./build.sh
./build.sh: line 259: $1: unbound variable
Change-Id: I2472c3451d6754f978f39b23a3492ed369151861
Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
The EnableTcssCovTypeA UPD definitions changed compared to the ADL/RPL FSP and the PCH XHCI port being mapped is not in a separate UPD anymore. Instead, it is passed in the same field as (previously boolean UINT8) EnableTcssCovTypeA. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
All TCSS XHCI ports are connected to a retimer (either TBT or USB3). These retimers already handle SBU pins and the orientation. Clear retimer bits: - for port 3 and 4 as they are not used - for port 2 as it has USB3 retimer with SBU orientation support Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
The default state of TBT force power GPIO was not consistent across variants. Assert TBT force power by default before FSP so that the initialization will be done when the retimer is active. De-assert TBT force power before handing off to the payload, so that the RTD3 logic will work in OS. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Match upstream version. The non-TBT USB2.0 port is routed the same way as for TBT port. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Mimic Intel's reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
TCSS XHCI ports that have a retimer connected should disable U1 and U2 transitions, as per Intel's reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Mimic Intel's reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Document #741494 says it is required for TCSS. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Report IRQ rotues as in reference code. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
There was a bug which assignd IRQ for device 2.2 instead of 2.0 by using wrong macro. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Document #741494 says to set these options. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
If DP tulleing and DP_ALT monitoring is enabeld in FSP for IOM, ACPI can notify IGD about HPD assertion and wake IGD from D3 hot. Add ACPI code to detect the HPD assertions and notify IGD if needed. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Enable TCSS to notify the IGD about hot plug events and eventually wake it up from D3 hot state. Disabel PS_ON feature, as it is only available on desktops. In Intel reference code it was involved in inhibiting the power gating of certain IP blocks. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
… platforms Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com>
The build_novacsutom function is used for boards that do not require LAN ROM. Remove obtaining the release binary and UEFIExtract as it is not used in the flow. Seems like a copy-pasta error. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
LAN ROM extarcton happened after the build, however the defconfigs already require the blob to be present during the build. Move the extraction before building the image. Fix the path to 3rdparty/blobs where the LAN ROM is expected to reside according to defconfigs. Also create the path ito ensure it exists. Build cbfstool and extarct the payload inside docker to avoid problems with hsot compilation and environment. Remove the spaces in the argument parsing for V5x0TU builds. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
This reverts commit 79fb20e. Upstream-Status: Inappropriate (revert of downstream commit) Change-Id: I1795dd345925010df11eed38b9da077235d9cff0 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
This reverts commit 64fa3c2. Upstream-Status: Inappropriate (revert of downstream commit) Change-Id: I650f1d95f9a06f8f262af91bac159e16656a2d8e Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
ESXi’s bootloader doesn’t properly parse 1GB page entries when it tries to replicate or interpret UEFI’s memory map/page tables during boot. This fixes the issue of the ESXi installer crashing on startup. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…anges Some of the changes to FSP params were introduced when attempting to resolve the MultiPhaseSiInit stage hang. Remove them, as they don't add any value after all. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
build.sh uses _ instead of - to separate components. Change-Id: I06d11509c130eb1556b907e0d8393cd995d118c1 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Wiktor Mowinski <wiktor.mowinski@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
- Set TBT_FORCE_PWR to low - Remove vGPIO configs - Use target pad macros in the iGPU variant Upstream-Status: Pending Change-Id: I84a1bfd0a9af146986338ee2616f9fa028f3476a Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: Iff59a7ae51e511e2fa61ebe5f2356022bd59d3f3 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
That is 0xFED40000-0xFED44FFF range which is first used by coreboot then by EDK and OSes to communicate with TPMs via CRB interface. Following an example from drivers/pc80/tpm/tis.c but using TPM_CRB_BASE_ADDRESS constant to match crb_tpm_fill_ssdt(). Change-Id: Id0cad2d95097653d6ab09731b2892e82122f3eac Upstream-Status: Pending Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Change-Id: I4b447b0d618a47bb9b2cb7e06c2715cc02d0a099 Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: I63393559d75b19078a18a99c51560f527cc3e328 Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
A commit adding an ID for the i219 in iPXE breaks the interface. It was reapplied during iPXE rebase, and needs to be reverted again. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Reapply the commit, guarding against NUC BOX which doesn't work well with it. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Reapply the commit, guarding against NUC BOX which doesn't work well with it. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Reapply the commit, guarding against NUC BOX which doesn't work well with it. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
… probing Set ROM_I2C_EN to expose the I2C USB-PD configuration EEPROM for probing within OS. This will allow later deployment of a patched binary to it, resolving USB-C power supply overdraw issues. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…resume Some FSPs do not program CPU features on S3 resume. Most likely they were built with gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesInitOnS3Resume set to FALSE by default. It was later fixed to be TRUE by default, but the FSPs did not pull this change. However, IoT FSPs provide an UPD to override this PCD. Use it to ensure the CPU features are programmed on S3 resume if FSP MP init is used and S3 resume is supported. TEST=Perform suspend/resume test with FWTS on ODROID-H4. Upstream-Status: Pending Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Upstream-Status: Inappropriate [custom edk2 fork] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Tested by booting into Ubuntu 24.04 on a NovaCustom V540TU and checking the state of the DescriptorWriteable EFI variable via efivarfs. Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: Ife03e252f41a58af269f44c8e99e9c627c51c79d Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Don't issue HMRFPO if Capsule Update is enabled, as HMRFPO causes a global reset which corrupts capsules. Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: I2dc0384360c1028d547c572f47f8a767abc61fe2 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Upstream-Status: Inappropriate [custom configs] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Change-Id: I523690e69d4b11a9978ef07dd88f40e69acbd43a Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Change-Id: Ib89a01b2e67b246aecb59f45f309c86c963144ff Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
filipleple
force-pushed
the
protectli_jsl_spd
branch
from
September 5, 2025 12:31
bd6e9f6 to
abe5054
Compare
Add the new SPD for the new V1410 hardware revision, extracted from the corresponding AMI binary. Also adds a comment note where further implementation should follow. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
filipleple
force-pushed
the
protectli_jsl_spd
branch
from
September 5, 2025 12:33
abe5054 to
fd0bb2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new SPD for the new V1410 hardware revision, extracted from the corresponding AMI binary. Also adds a comment note where further implementation should follow.
Upstream-Status: Pending