Issue261 switch#329
Open
Nicsda wants to merge 17 commits into
Open
Conversation
added 17 commits
May 29, 2026 17:03
…false, then indicator appears)
…y the type and not its path get displayed in the parameter dialog window
…nput) and added/adjusted the documentation in both pCV and mCV
…ters forwarded from top-level to single valves yet
…uding invertInput; more extensive test model, needs to be tidied up
…e again from Switch Issue 261
…valves according to the corresponding outlet
…added corresponding documentation
Collaborator
|
It looks like reviewer, assignee, and a corresponding issue are still missing. |
Contributor
There was a problem hiding this comment.
i would remove this file change - intentional? ... maybe consistency?
| experiment(StopTime=10, Tolerance=1e-6, Interval=0.01, __Dymola_Algorithm="Dassl"), | ||
| Documentation(info="<html> | ||
| <p>Test for the switches.</p> | ||
| <p>Owner: Michael Meißner</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p>Owner: Michael Meißner</p> | |
| <p>Owner: Niclas Dotzauer</p> |
| experiment(StopTime=10, Tolerance=1e-6, Interval=0.01, __Dymola_Algorithm="Dassl"), | ||
| Documentation(info="<html> | ||
| <p>Test for the switches.</p> | ||
| <p>Owner: Michael Meißner</p> |
| annotation(Dialog(group = "Valve parameters",enable = (flowCoefficient ==FlowCoeffType.m_flow_set))); | ||
| parameter Real k_min(unit="1", min = 1e-5, max = 1) = 0.03 "Remaining flow at actuation signal u = 0"; | ||
|
|
||
| parameter SI.Pressure p_ref = 1e5 "Reference pressure"; |
Contributor
There was a problem hiding this comment.
Suggested change
| parameter SI.Pressure p_ref = 1e5 "Reference pressure"; | |
| "; |
not used
| ThermofluidStream.Interfaces.Outlet outletB(redeclare package Medium=Medium) | ||
| annotation (Placement(transformation(extent={{-20,-20},{20,20}},rotation=90,origin={0,100}))); | ||
|
|
||
| Modelica.Blocks.Interfaces.RealInput u(min=0, max=1, unit="1") "Flow split" |
Contributor
There was a problem hiding this comment.
Suggested change
| Modelica.Blocks.Interfaces.RealInput u(min=0, max=1, unit="1") "Flow split" | |
| Modelica.Blocks.Interfaces.RealInput u(min=0, max=1, unit="1") "Control signal for valve openings" |
| parameter Real k_min(unit="1", min = 1e-5, max = 1) = 0.03 "Remaining flow at actuation signal u = 0"; | ||
|
|
||
| parameter SI.Pressure p_ref = 1e5 "Reference pressure"; | ||
| parameter Boolean invertInput = false "=true, if input single is inverted" annotation (Evaluate=true, HideResult=true, choices(checkBox=true)); |
Contributor
There was a problem hiding this comment.
Suggested change
| parameter Boolean invertInput = false "=true, if input single is inverted" annotation (Evaluate=true, HideResult=true, choices(checkBox=true)); | |
| parameter Boolean invertInput = false "=true, if the control input is inverted" annotation (Evaluate=true, HideResult=true, choices(checkBox=true)); |
Spelling mistake
| @@ -0,0 +1,180 @@ | |||
| within ThermofluidStream.FlowControl; | |||
| model ThreeWayValve "to control e.g. bypass flows" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| model ThreeWayValve "to control e.g. bypass flows" | |
| model ThreeWayValve "Three-way valve for continuously controlling complementary branch openings" |
| annotation (Diagram(coordinateSystem(extent={{-120,-100},{100,100}})), | ||
| experiment(StopTime=10, Tolerance=1e-6, Interval=0.01, __Dymola_Algorithm="Dassl"), | ||
| Documentation(info="<html> | ||
| <p>Test for the switches.</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| <p>Test for the switches.</p> | |
| <p>Test for the three-way valve component.</p> |
Prbly copy paste error ;)
tobiasreischl
requested changes
Jun 15, 2026
tobiasreischl
left a comment
tobiasreischl
left a comment
Contributor
There was a problem hiding this comment.
Minor changes suggested directly - but mostly stuff to make it appear clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made Switch and its test case obsolete (only cosmetically to be able to push this to a minor release) and added documentation accordingly.
Created the new ThreeWayValve model very similar to the switch model but with BasicControlValves. Apparently, the same parameterization as for the switch still works. Also added a pointer in the icon to visualize the opening position.
Regression Test: everything validated, except of course the new "FlowControl.Tests.ThreeWayValve"