Repository navigation
Fix multiple response filters without entity metadata - #504
Merged
Merged
Conversation
slobodan-ilic
force-pushed
the
issue-503-mr-filter-entity
branch
6 times, most recently
from
July 13, 2026 13:17
ef8c117 to
2983e18
Compare
jjdelc
approved these changes
Jul 14, 2026
| def _get_categories_from_var_index(vars_by_alias, var_alias): | ||
| return vars_by_alias[var_alias].entity.body.categories | ||
| """Return subvariable alias -> id from table metadata subreferences.""" | ||
| subreferences = var_index[var_url].get("subreferences", {}) |
Contributor
There was a problem hiding this comment.
Suggested change
| subreferences = var_index[var_url].get("subreferences", {}) | |
| subreferences = var_index[var_url].get("subreferences", {}) or {} |
I've found this pattern bits me when the key exists and the value is None. In this case it's going to be super duper weird for this to happen though.
Contributor
Author
There was a problem hiding this comment.
fixed, thanks!
slobodan-ilic
force-pushed
the
issue-503-mr-filter-entity
branch
from
July 15, 2026 08:36
2983e18 to
ef0441d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary