docs(server): record the rule that publish diagnostics established - #398
Open
mostafasadeghidev wants to merge 1 commit into
Open
docs(server): record the rule that publish diagnostics established#398mostafasadeghidev wants to merge 1 commit into
mostafasadeghidev wants to merge 1 commit into
Conversation
`RuntimeScriptBuildError` and its 422 landed in e9e99df, but the error handling section still described only the two existing shapes: typed domain errors, and the generic 500 for invariants. A reader following that section would reach for a plain `throw` and their message would vanish into the catch-all — which is exactly the bug that fix repaired. The rule the fix embodies is worth stating where the next person will look for it: when a failure is the author's to fix, intercept it before the generic 500 rather than relying on the log. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuntimeScriptBuildErrorand its 422 landed in e9e99df, butdocs/server.md's error-handling section still describes only the two shapes that predate it: typed domain errors with apath, and the genericErrorfor invariants that fall through to a 500.Someone following that section today would reach for a plain
throwand watch their message disappear into the catch-all — which is the bug that fix repaired. This adds the third rule, with the diagnostics work as its worked example, so the next person finds it where they'd look.Docs only. No code changes.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com