Skip to content

fix(installer): resolve latest stable plugin release - #85

Merged
gofenix merged 2 commits into
mainfrom
fix/install-latest-dsh-plugin
Aug 31, 2026
Merged

gofenix merged 2 commits into
mainfrom
fix/install-latest-dsh-plugin

Conversation

@gofenix

@gofenix gofenix commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • make the macOS installer resolve the highest stable dsh-coremate-mobile-v* GitHub Release at runtime
  • follow GitHub pagination until every Release page has been considered
  • ignore draft, prerelease, and unrelated OpenGUI releases
  • retain --version VERSION and an environment override for rollback and reproducible installs
  • keep package and checksum downloads bound to the same resolved Release
  • point the public Codex installation prompt at the stable Skill on main
  • update the release workflow so future Release notes keep the stable installer entry point

Validation

  • bash -n skills/opengui-coremate-install/scripts/install-macos.sh
  • pnpm install --frozen-lockfile
  • pnpm run check
  • 39 test files passed
  • 213 tests passed, 1 skipped
  • added coverage for selecting the highest stable version from a later API page while filtering unrelated, draft, and prerelease tags

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-31T04:51:49.675657Z cc066dc New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8cf4b5395

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github_repository="Core-Mate/OpenGUI"
release_version="${COREMATE_INSTALL_VERSION_OVERRIDE:-}"
github_release_base="https://github.com/${github_repository}/releases/download"
github_releases_api="${COREMATE_INSTALL_RELEASES_API_OVERRIDE:-https://api.github.com/repos/${github_repository}/releases?per_page=100}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge 遍历所有分页后再选择最高稳定版本

当仓库累计超过 100 个 Release,尤其是首页被其他产品的 Release、草稿或预发布版本占满时,该 URL 只请求第一页,而后续逻辑只会在这 100 条记录中排序。这会导致默认安装器错误地选择较低版本,或在后续页仍存在稳定插件 Release 时报告找不到版本;应跟随 GitHub 的分页链接收集所有候选项后再选择最高版本。

Useful? React with 👍 / 👎.

@gofenix
gofenix merged commit 8a541b0 into main Aug 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant