Skip to content

[1/5] refactor: rename InferenceChecker to ConflictChecker - #605

Open
EmirDe wants to merge 1 commit into
mainfrom
features/checkers-1-conflict-checker-rename
Open

EmirDe wants to merge 1 commit into
mainfrom
features/checkers-1-conflict-checker-rename

Conversation

@EmirDe

@EmirDe EmirDe commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Renames the InferenceChecker trait, its implementations and the fields that hold them to ConflictChecker and conflict_checker(s). A checker decides whether a set of premises is a conflict of a rule, which the new name says.

  • No behavioural change; the diff is the rename only.
  • check_inference and RejectedInference keep their names: they still describe checking one inference.

Review order:

  • the trait file in pumpkin-checking, renamed from inference_checker.rs to conflict_checker.rs;
  • where checkers are stored and called in pumpkin-core (propagation/runtime_checkers.rs, engine/state.rs, checkers/store.rs);
  • the implementations in pumpkin-core (nogoods, hypercube linear, reified);
  • the implementations in pumpkin-propagators, one file per constraint;
  • documentation.

Stack: 1/5, based on main.

@ImkoMarijnissen ImkoMarijnissen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the rename looks good to me; I find InferenceChecker a bit more clear in what its purpose is, but I understand that in the context of conflict rules, this naming makes sense

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants