T3490 together confirmation de translations - #408
Merged
Merged
Conversation
The .po files still held the v14 Jinja texts of the bodies and subjects of the TOGETHER donation and project email templates. Loading the translations (overwrite, or updating them from the interface) replaced the repaired templates with them again. These templates are maintained in the database by migrations: remove these entries.
The confirmation heading was built from separately translated fragments
("Thank you for" + "launching"/"joining" + "a project !"): German
word order could not fit them, and the page showed "Danke für ein
Projekt startest! ein Projekt!".
Use one full sentence per case, and better German texts matching the
English ones. The old fragments are removed from the translations.
- A new project was merged into a pending email of the same owner, and the templates then failed with several projects (validating a second project raised "Expected singleton"). The project creation, project joined and project published emails are no longer merged. - "Project published" and "Project joined" still had Jinja in German, French and Italian: rewritten in QWeb, keeping their wording. - "Project creation confirmation": French subject with the forms of address swapped, and a typo in the French text.
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- "Project joined" links to the page of the person who joined: the donations made there are credited to them, not to the project owner. - Only replace the languages still written in Jinja, and the French subject only while it has the forms of address swapped: English and any text already corrected by hand are kept.
The French subject of the project creation confirmation is stored as
${...} in v14 and as {{...}} once converted: match both, so the
swapped forms of address are corrected on every upgraded database.
ecino
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T3490 — Fix German translations on TOGETHER confirmation page
Original report
Quality test "TOGETHER: Create a project", step 6 (submit the project form): the confirmation page was wrong in German. French was fine. While testing the rest of the scenario (project validation, communications), two more problems showed up.
Root causes
Confirmation page (step 6). The heading of the
step3_formend message was built from separately translated fragments:Thank you for+<span t-if>launching</span>/<span t-else>joining</span>+a project !. German word order cannot fit fragments, so the page showed "Danke für ein Projekt startest! ein Projekt!". The e-mail sentence also said something else than the English ("you will be informed about the next steps")."Expected singleton" when validating a second project.
partner.communication.job.create()merges a new communication into a pending one of the same partner and rule. When the owner still had a pending "Project published" email for a first project, validating a second project merged both into one job, and the template (written for one project) failed:Expected singleton: crowdfunding.project(201, 207). Same for the creation and joined confirmations.Broken project emails. "Project published" and "Project joined" still held v14 Jinja (
% set ...,${...}) in German, French and Italian. "Project creation confirmation" had its French subject with the forms of address swapped (tu/vous) and a typo.Stale translations. The
.pofiles still held the v14 Jinja texts of the bodies and subjects of the five TOGETHER email templates (including the two donation templates repaired in T3491). Loading translations with overwrite (or from the interface) replaced the repaired templates with them again.Changes
251fbb2— Drop the old translations of the TOGETHER email templates: removes themodel:mail.template,body_html/subjectentries of the five templates from de/fr_CH/it (maintained in the database by migrations).de7265d— Fix the German texts of the project confirmation page: one full sentence per case (t-if/t-else), new German texts, old fragments removed from the translations.d26a307— One email per project and repaired TOGETHER project emails:forbid_mergingon the three project rules (XML + migration), QWeb rewrite of "Project published" and "Project joined" in the four languages (wording kept, link to the project page), French subject and typo of "Project creation confirmation".German confirmation texts:
How to test manually
${...}or% setlines, link to the project.Locally, Mailpit (
localhost:1025) must be running: otherwise the automatic confirmation email fails and makes the project form submission fail (HTTP 500).