Skip to content

Reintroduce BaseContractTest class that was not migrated from Odoo 14 - #284

Merged
ecino merged 1 commit into
18.0from
new-donor-onboarding-tours
Sep 2, 2026
Merged

ecino merged 1 commit into
18.0from
new-donor-onboarding-tours

Conversation

@AlexandrePhilibert

@AlexandrePhilibert AlexandrePhilibert commented Sep 1, 2026 •

Copy link
Copy Markdown

Reintroduce the BaseContractTest class that is required for the new donor onboarding tours test.

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The restored fixture is compatible with the current downstream consumer hierarchy and is safe to merge.

No defects remain after the executed downstream compatibility check disproved the only failure hypothesis. Odoo runtime execution is unavailable locally, but the changed fixture API and its active cross-repository use were directly checked.

Files Needing Attention: No files need changes. An Odoo-provisioned environment can additionally run the addon test suite when available.

T-Rex T-Rex Logs

What T-Rex did

  • The base contract validation script was executed and exited with RESULT=PASS, confirming the inheritance chain does not rely on fixture members omitted from this restoration.
  • A broader Python validation was attempted by compiling tests and importing Odoo; the compile completed but the runtime import failed with ModuleNotFoundError: No module named 'odoo' because Odoo is not installed in this environment.
  • Related artifacts documenting the contract validation and Odoo-import attempt were collected and archived to support review.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (1): Last reviewed commit: "FEAT: Reintroduce BaseContractTest class..." | Re-trigger Greptile

@ecino
ecino merged commit b790c40 into 18.0 Sep 2, 2026
2 checks passed
@ecino
ecino deleted the new-donor-onboarding-tours branch September 2, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants