fix(audio/windows): set waveformat when needed#1460
Open
HarmfulBreeze wants to merge 2 commits into
Open
Conversation
The waveformat should not be set on every client connection, as it could stop the audio sessions for some games (like Slay the Spire). This patch addresses this issue by adding a simple cache map meant to remember device_id <-> waveformat associations, and only changing the waveformat if needed.
HarmfulBreeze
changed the title
Author
|
@ClassicOldSong friendly bump :) |
Owner
|
Sorry I was really busy recently and I forgot to take a look afterwards... |
brain fart I guess
Author
|
It's fine, no worries. :) Thanks for your feedback. I reverted the error logging in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The waveformat should not be set on every client connection, as it could stop the audio sessions for some games (like Slay the Spire).
This PR addresses this issue by adding a simple cache map meant to remember device_id <-> waveformat associations, and only changing the waveformat if needed.