fix: resolve #963 — br error on Right/open of md associated editor (zsh/vscode) - #1168
Open
chinhkrb113 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When broot opens a file with an associated GUI editor (e.g. VSCode on Windows/msys2), the editor is launched as a background program (switch_terminal = false). broot currently spawns this child without redirecting its stdin/stdout/stderr, so any diagnostic output the editor writes (deprecation warnings, jump-list privacy errors, extension host messages) is written straight into broot's terminal and surfaces as the "error" the user sees in this issue. The fix is to fully detach background programs from broot's terminal by piping their standard streams to null. This keeps broot's TUI clean and matches the intent that background launches should not share broot's console
Fixes #963
Changes
src/launchable.rsWhy
src/launchable.rs: When broot opens a file with an associated GUI editor (e.g. VSCode on Windows/msys2), the editor is launched as a background program (switch_terminal = false). broot currently spawns this child without redirecting its stdin/stdout/stderr, so any diagnostic output the editor writes (deprecation warnings, jump-list privacy errors, extension host messages) is written straight into broot's terminal and surfaces as the "error" the user sees in this issue. The fix is to fully detach background programs from broot's terminal by piping their standard streams to null. This keeps broot's TUI clean and matches the intent that background launches should not share broot's console.