Adding preview_layout - #1139
Open
arpadav wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a similar problem as @j-xella in #1059, where I used broot in a narrow-fashion
This was my attempted at adding a vertical-stacking mode as opposed to the only horizontal-tiling.
PREFACE
areas.inputrendering (see video below)move_panel_divider/set_panel_widthis not yet implementedMain changes
preview_layoutto config. Options includeright(default) andbottomhas_preview: bool->preview_layout: Option<PreviewLayout>, whereNoneis analogous tofalseBrowserState::effective_page_heightAreas::compute_areasto change the preview area to be vertically stacked, with an early returnHelp requested
In
Areas::compute_areasis where the majority of the logic is for how the vertical stacking is implemented.I can't seem to wrap my head around how the
areas.inputis being rendered, since I tried many configurations and doesn't seem to work. In addition, this single conditional with early return is just my somewhat hacky attempt at this problem, but unsure if there are better alternative ways to structure the code.In addition, it is also in
Areas::compute_areaswhere thelayout_instructionsare passed in and modified. However, I did not want to change the logic before getting any guidance onset_panel_widthto something else, or keep the term as "width"?Showcase
You can see that:
Screencast.from.2026-03-05.17-20-16.webm