FIREFLY-2066: Consolidate the loading UI of Spectral Lines feature - #2015
Open
jaladh-singhal wants to merge 21 commits into
Open
jaladh-singhal wants to merge 21 commits into
jaladh-singhal wants to merge 21 commits into
Conversation
…nd plotting clear
Fix the layout styling issues with NoDataTableView
jaladh-singhal
commented
Sep 12, 2026
| // Recommended spectral line lists in the Spectral Lines panel: a JSON array of {label, src} objects, in order. | ||
| // Omit "src" to use one of Firefly's bundled lists - any other label with no src is dropped (logged as an error). | ||
| // Set to "[]" to offer no spectral line lists at startup. | ||
| charts.spectrum.linelists = "[{\"label\": \"SPHEREx line list\"}, {\"label\": \"Spitzer PAHFIT line list\"}, {\"label\": \"Herschel HSPOT line list\"}, {\"label\": \"JWST line list (remote)\", \"src\": \"https://gist.githubusercontent.com/jaladh-singhal/2b4230e2fc64586fbe7b51519d26ad3f/raw/21f503d13bc0e859d269d8acc782083f7fa84c7e/jwst_linelist.tbl\"}]" |
Member
Author
There was a problem hiding this comment.
NOTE: Last option "JWST line list (remote)" is just a test for recommended/pre-installed line list coming from a remote server rather than bundling with firefly static resources.
I plan to remove it when merging this PR.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes FIREFLY-2066
SpectralLinesPanel- loading is a separate concern from per-trace display options, and the panel is shared app-wide, not per-chartcharts.spectrum.linelistsapp-config property ({label, src?}array,srccan be a bundled resource or remote URL) instead of one hardcoded combined CSV - retiredlinelist_combined.csvfor separatehspot_lines.csv/pahfit_lines.csv/spherex_lines.tblresources plus a remote JWST list as a src-as-URL examplespectral-lines), rebuilt only on explicit "Load Lines"/"Clear All", never automatically on checkbox/mapping changeSpectralLinesProcessorwarns server-side when an available line list's wavelength column has no units metadata, and the upload column mapper shows similar feedback for the uploaded file's wavelength columnAdditional changes/cleanup:
UploadTableSelectorenhanced for use inSpectralLinesPanel: addedallowClear(adds a chip to clear the uploaded file),uploadTblOptions(keeps the upload out of the main Results view), and a per-fieldgetFeedbackhook (surfaces the uploaded wavelength column's detected/assumed unit)SpectrumOptions: Standardized default resolution logic for redshift options (getEffectiveSpectralFrameOption) and de-duplicated a few hardcoded spectral-frame/redshift constantsSpectrumUnitConversion(for SPHEREx spectrum results)BasicTableViewTesting
All the test files linked in the ticket.
https://firefly-2066-spec-lines-loading.irsakubedev.ipac.caltech.edu/firefly
Core functionality
Upload line list
Redshift correction
0.5and "Apply" -> spectral lines should redshift right of their lines-table wavelength. Switch to "Rest Frame" with the same redshift and "Apply" -> lines return to their original wavelength and the spectrum blueshifts left instead. Net effect: lines and spectrum end up in the same relative position, just with the X-axis shifted - confirming the correction applies correctly in both framesRegression