Skip to content

feat(NS): 添加识别码示例#6045

Open
502y wants to merge 11 commits into
mainfrom
feat/namespace_identifier
Open

feat(NS): 添加识别码示例#6045
502y wants to merge 11 commits into
mainfrom
feat/namespace_identifier

Conversation

@502y

@502y 502y commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@cfpa-bot cfpa-bot Bot added 1+ 行数标签 config PR 中的更改涉及 Config 文件夹 labels Jun 13, 2026
@boring-cyborg boring-cyborg Bot added 1.12.x Minecraft 版本标签 Forge 包含 Forge 模组 labels Jun 13, 2026
@cfpa-bot

cfpa-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor


ℹ 此 PR 没有检测到 CurseForge/Modrinth 模组修改。


ℹ 此 PR 没有更改语言文件或者 PR-Packer 出现了问题。


⚠ 检测到一个语言文件,但提交路径不正常。请检查提交路径:Unofficial/lang/zh_cn.lang
⚠ 检测到一个语言文件,但提交路径不正常。请检查提交路径:Stuff/lang/zh_cn.lang


🔛 Diff:


🐖 命令列表 | 问题反馈

  • 🔄 勾选这个复选框来强制刷新

Comment thread config/packer/1.12.2.json Outdated
@cfpa-bot cfpa-bot Bot added 10+ 行数标签 source and removed 1+ 行数标签 labels Jun 15, 2026
@cfpa-bot cfpa-bot Bot removed the source label Jun 21, 2026
@502y 502y requested review from dovisutu and mamaruo June 21, 2026 12:11
@SlimeSB

SlimeSB commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

LGTM,实际看下来有些散在各处了
或许构建manifest的活可以交给packer干。

我目前的想法是同一个ns的discriminator必须来源一致,不然没法下发和比较,放local-config会有多个重复

感觉或许不用这个spec?不过更灵活的或许yagni,就是怕再加就晚了。毕竟还有create一大坨联动等等。

"namespaceDiscriminator": "AE2 Stuff"

suggest:

"nsCutMatch": "AE2 Stuff"

"namespaceDiscriminator": {
    "ae2-stuff": "displayName"
}

suggest:

"nsPickRule": {
    "ae2-stuff": "displayName"
}

@SlimeSB

SlimeSB commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

refactor: 将全局config中nsPickRule移动到**/local-config.json

将config/packer/1.12.2.json中:

"namespaceDiscriminator": {
    "ae2-stuff": "displayName"
}

改为nsPickRule,并移动到projects/assets/ae2-stuff/1.12.2/ae2stuff/local-config.json
原namespaceDiscriminator改为nsCutMatch
移动后:

...

  "destinationReplacement": {},
  "nsPickRule": "displayName",
  "nsCutMatch": "AE2 Stuff"
}

@mamaruo

mamaruo commented Jun 24, 2026

Copy link
Copy Markdown
Member

支持两种字段不同名。其他看 @dovisutu 的实现意见

@502y 502y marked this pull request as ready for review June 28, 2026 09:09
SlimeSB

This comment was marked as outdated.

Comment thread config/packer/namespace-discriminator.json Outdated
Co-authored-by: SlimeSB <86453765+SlimeSB@users.noreply.github.com>

@SlimeSB SlimeSB left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GGWP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.12.x Minecraft 版本标签 10+ 行数标签 config PR 中的更改涉及 Config 文件夹 Forge 包含 Forge 模组

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants