Confirm the banner renders as a callout (spec 011, Task 3.5) - #75
Merged
Conversation
The last leftover from requirements Q1, and it needed a published branch. PR #74 merged first, so it was checked against the live site rather than a preview. GitBook emits <h1> ... </header>, then the banner as the first element of the content body: <blockquote class="... border-l-2 pl-6 py-3 ...">. A real blockquote with a left border and padding -- a callout below the title, which is what the task asked. Inside it **Reference** becomes <strong>, the " . " separators survive as U+00B7, and the Prerequisites link is a real <a href> returning 200. 12 pages sampled across the corpus, including all five that carry a Prerequisites segment. That segment had never appeared in a rendered page until the Phase 6 splits created pages using it, so this is the first time the optional half of the banner grammar has been checkable at all. The obvious check would have proved nothing. Reading a page through a Markdown-converting fetcher returns "> **Explanation** . Applies to ...", which is exactly what a correctly rendered blockquote converts back to, and equally what an unrendered literal banner would look like. The two are indistinguishable after conversion -- and GitBook emitting front matter and blockquotes literally was the concern behind Q1 in the first place. The check had to be run against raw HTML for the <blockquote> element, and was. Also settled: the published site is 111 URLs (sitemap-pages.xml), being 110 pages plus the index, so all five split pages are live and none is orphaned in the published tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012tcdwxVb8NmKaX2S6fvyFg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last leftover from Spec 011's requirements Q1: does the page banner actually
render as a callout below the title, or does GitBook emit it literally?
It needed a published branch, and #74 supplied one by merging — so this was checked
against the live site rather than a preview revision. Documentation only; no page
under
contents/is touched.What was checked
GitBook emits
<h1>…</header>, then the banner as the first element of the contentbody:
A real blockquote with a left border and padding — a callout below the title, which is
what the convention asks for.
**Reference**becomes<strong>, the·separatorssurvive as U+00B7, and the Prerequisites link is a genuine anchor (fetched: 200).
12 pages sampled across the corpus, including all five that carry a Prerequisites
segment. That half of the banner grammar had never appeared in a rendered page until
the Phase 6 splits created pages using it, so this is the first time it has been
checkable at all.
The check that would have proved nothing
The first attempt read the page through a Markdown-converting fetcher, which returned:
That is exactly what a correctly rendered blockquote converts back to — and equally
what an unrendered literal banner would look like. The two are indistinguishable
after conversion, and GitBook rendering such things literally is precisely the concern
behind Q1. The check had to be run against raw HTML for the
<blockquote>element, andwas.
Also settled
The published site is 111 URLs (
sitemap-pages.xml) — 110 pages plus the index — soall five pages created by the Phase 6 splits are live, and none is orphaned in the
published tree.
Verification
Spec 011 is now 40 of 43 tasks. Remaining: the language-tag backfill,
--fixforpagelint.py, and the acceptance pass.🤖 Generated with Claude Code
https://claude.ai/code/session_012tcdwxVb8NmKaX2S6fvyFg