Add notes - #394
Open
j-or wants to merge 20 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rows may carry different optional meta keys (e.g. note vs description); the CSV header is the union of all meta keys, so each row's meta values must be written in header order rather than the row's own key order. Otherwise a value could land under the wrong column and be mis-read on re-import. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The note indicator becomes an icon-button aligned with the edit button. Clicking it opens a minimalist MUI Popover with a single-line input prefilled with the note and three small icon buttons: save, cancel, delete. Hover still shows the note tooltip (truncated to NOTE_TOOLTIP_MAX chars). Save/delete persist through a new setNote updater in useDataPoints, threaded as an onRowNoteChanged/onNoteChanged callback (data-points -> editable-table -> row -> collapsed-row), mirroring the existing enable/disable path. Persistence stays in data-points via onUpdateDataPoints; no new reducer action. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ints Factor/variable names are matched by exact === everywhere (including CSV import), so leading/trailing whitespace silently breaks matching. Trim the name in addValueVariable, editValueVariable, addCategorialVariable and editCategoricalVariable; on rename keep data-point names and constraint dimensions in lockstep with the trimmed new name.
…ugh CSV DataPoints gains csvSeparator (default ';'), passed to dataPointsToCSV on download and forwarded to UploadCSVButton's new separator prop, which in turn passes it to csvToDataPoints. No selector UI or local state in the package; the value is chosen by a global user setting in brownie-bee.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.