Implement keepalive messages for SSE connections - #829
Merged
Conversation
Implements sending a comment (`:`) every 30 seconds if no other event has been enqueued to prevent the connection from timing out and being closed.
This allows `SseConnectionManager.broadcast` to create a single object and give it to all the `SseConnection` instances instead of `SseConnection.enqueue` having to instantiate a new `String[]` each time. It also makes the logic that sends keepalives cleaner.
pR0Ps
force-pushed
the
bugfix/sse-keepalive
branch
from
August 7, 2026 04:27
e20ef6e to
5c69501
Compare
pR0Ps
commented
Aug 7, 2026
TBlueF
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sending an SSE comment (
:) every 30 seconds if no other event has been enqueued to prevent the connection from timing out and being closed.