Fix mouse handler binding for talking book tool (BL-16366)#8000
Open
StephenMcConnel wants to merge 1 commit into
Open
Fix mouse handler binding for talking book tool (BL-16366)#8000StephenMcConnel wants to merge 1 commit into
StephenMcConnel wants to merge 1 commit into
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| src/BloomBrowserUI/bookEdit/toolbox/talkingBook/audioRecording.ts | Rewires all toolbar button handlers to use jQuery delegated events on $(document) with namespaced events so they survive toolbox DOM re-hydration; converts audioLevelListener/micErrorListener to arrow-function class fields and adds remove-before-add idempotency; extracts wirePlayerHandlers() and tracks wiredPlayer to re-attach non-bubbling media events after re-hydration. |
| src/BloomBrowserUI/utils/WebSocketManager.ts | Adds an early-return guard in removeListener when clientContext has no registered callbacks, preventing a crash when removeListener is called before any addListener for that context. |
Reviews (3): Last reviewed commit: "Fix mouse handler binding for talking bo..." | Re-trigger Greptile
ad9b2b0 to
dd9237c
Compare
Also a bit of cleanup in that general area as well. I'm not sure these changes are needed in 6.5 since the bug was not manifesting there.
dd9237c to
28135c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a bit of cleanup in that general area as well. I'm not sure these changes are needed in 6.5 since the bug was not manifesting there.
This change is