Add sorting to is_consistent function for deterministic error ordering#381
Merged
LesterEvSe merged 1 commit intoJul 23, 2026
Conversation
LesterEvSe
force-pushed
the
refactor/hashmap-to-btreemap
branch
from
July 23, 2026 09:12
15b9ec5 to
6d4e8b2
Compare
LesterEvSe
changed the title
HashMap in witness.rs with BTreeMap for deterministic error orderingis_consistent function for deterministic error ordering
LesterEvSe
force-pushed
the
refactor/hashmap-to-btreemap
branch
from
July 23, 2026 09:28
6d4e8b2 to
4a21dcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error output ordering was nondeterministic because
ArgumentsandWitnessusedHashMapinternally, causing diagnostics to be emitted in arbitrary iteration order across runs.This PR add sorting to
is_consistentfor deterministic error ordering.