test(models): drop the post-top-models exemptions, ClawRouter #290 landed them - #33
Merged
Merged
Conversation
…nded them gemini-3.6-flash, gemini-3.5-flash-lite, tencent/hy3 and mimo-v2.5-pro are now in ClawRouter's top-models.json, so the mirror guard can check them directly. Exemptions that outlive their reason are worse than no exemption: they silence the guard for real drift on those ids. All 55 curated entries are back under the check with no carve-outs — POST_TOP_MODELS_ADDITIONS and CURATED_PLACEMENT_OVERRIDES are both empty. 83 passed with a sibling ClawRouter checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClawRouter #290 added
gemini-3.6-flash,gemini-3.5-flash-lite,tencent/hy3andxiaomi/mimo-v2.5-prototop-models.json, which is whatPOST_TOP_MODELS_ADDITIONSexisted to work around. Emptying it puts all four back undertest_curated_picker_catalog_mirrors_clawrouter_top_models.An exemption that outlives its reason is worse than no exemption: it silences the guard for real drift on exactly those ids.
All 55 curated entries are now checked with no carve-outs —
POST_TOP_MODELS_ADDITIONSandCURATED_PLACEMENT_OVERRIDESare both empty, andmodels.pymirrorstop-models.jsonentry for entry and in order.Tests
python3 -m pytestwith a sibling ClawRouter checkout: 83 passed, 3 skipped.Note the guard
pytest.skips without that sibling checkout, so CI here will report 82 passed / 4 skipped — it cannot exercise this change. Verified locally against ClawRoutermainat 7cf2547.