MOB-53647 Aggregator: skip labels without dash in extend-aggregation - #2021
Closed
devership16 wants to merge 2 commits into
Closed
MOB-53647 Aggregator: skip labels without dash in extend-aggregation#2021devership16 wants to merge 2 commits into
devership16 wants to merge 2 commits into
Conversation
Guard __extend_reported_data against labels that lack a '-state' suffix.
When extend-aggregation is true and a label has no dash, key.rindex('-')
raises ValueError crashing taurus. This defensive fix skips such labels.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
devership16
requested review from
henrychv and
pjain05
and
a balanced review from Copilot
September 2, 2026 10:19
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2021 +/- ##
==========================================
+ Coverage 88.19% 88.19% +0.01%
==========================================
Files 75 75
Lines 21162 21164 +2
==========================================
+ Hits 18661 18663 +2
Misses 2501 2501 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Skipped labels can cause existing overall KPI data to be silently erased.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prevents extended aggregation from crashing on labels without state suffixes.
Changes:
- Skips labels lacking
-. - Adds regression coverage for undashed labels.
File summaries
| File | Description |
|---|---|
bzt/modules/aggregator.py |
Adds defensive label handling. |
tests/unit/modules/test_consolidatingAggregator.py |
Adds regression test. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pjain05
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__extend_reported_data: skip labels without-separator instead of crashing withValueError: substring not foundextend-aggregation: trueis injected by the BZM backend, labels without a-statesuffix (e.g. selenium test labels liketest_index) causedkey.rindex('-')to crash taurusRoot Cause
isTransactionFilterAllowed()(a.blazemeter.com) was broadened to include selenium executors, which sethasTransactionsFilter = true→TaurusExecutorConfigurationinjectedextend-aggregation: true→ConsolidatingAggregator.__extend_reported_data()crashed on labels without-.Companion PHP fix: Blazemeter/a.blazemeter.com (narrows
isTransactionFilterAllowed()to BBT-only selenium).Test plan
test_extend_data_labels_without_dash— new unit test for labels without-test_extend_dataandtest_extend_data_avg— existing tests still pass🤖 Generated with Claude Code