Collect in-flight requests on Thread Group duration end - #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the BlazeMeter HTTP Async Controller: it now ensures that when a thread group is configured to run for a fixed duration, any HTTP requests already dispatched by the controller are allowed to complete and be reported before the thread ends. This prevents losing in-flight results at the scheduled end of the run, improving result accuracy and consistency. The grace period for this behavior is configurable via a new property. The pull request also adds comprehensive documentation for this feature and for low-level logging and debugging options.
Enhancements to request completion and scheduling:
blazemeter.http.schedulerHoldMillisproperty, which can be tuned or disabled as needed. The property is documented in both the code and theREADME.md. [1] [2] [3] [4] [5]Documentation improvements:
README.mdto explain the new request completion behavior, theblazemeter.http.schedulerHoldMillisproperty, and its effect on test runs with a scheduled duration. [1] [2]Code quality and maintainability:
LOG.debugcalls with the plugin's internallowLevelDebugmethod for more consistent and configurable low-level tracing. [1] [2] [3]These changes make the plugin more robust in scheduled runs, improve the accuracy of reported results, and provide better tools for diagnosing and debugging HTTP request execution.