Fix timing issues in samplers - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for accurately measuring and configuring how parent samples in the HTTP Async Controller report their duration, aligning with JMeter's Transaction Controller behavior and fixing timing issues with think times and pre/post-processors. It adds a new option to include or exclude timer and processor durations in the generated parent sample, updates the GUI to expose this option, and refines how sample timings are tracked and reported.
New Feature: Parent Sample Timing Configuration
HTTP2ControllerGUI.java) to include a checkbox for this setting, which is only enabled when "Generate Parent Sample" is selected. The checkbox state is synchronized with the controller's configuration [1] [2] [3] [4] [5] [6].Accurate Sample Timing and Measurement
Timing Infrastructure Improvements
Stampmechanism inHTTP2FutureResponseListenerto accurately track both wall clock and monotonic times for request start and end, improving reliability and correctness of sample timestamps [1] [2].Compatibility and Defaults
These changes collectively improve the accuracy, configurability, and reliability of parent sample timing in the HTTP Async Controller, addressing longstanding issues with transaction time reporting and aligning behavior with user expectations.