Add AKS konnectivity-agent validation step - #1296
Conversation
Functional validator that execs into a temporary busybox pod to verify the control-plane-to-node konnectivity tunnel works.
|
For reviewers only: reply |
| @@ -0,0 +1,29 @@ | |||
| import azure_pipelines.ap.steps | |||
There was a problem hiding this comment.
I think this file should live in lib/steps/k8s, since it's more related to k8s. Though it uses AzCli, this can easily adapt to other cloud.
I don't think I noticed this before, so it may apply to your past PRs.
There was a problem hiding this comment.
Thanks, I was thinking the same thing. A few of these checks are Azure-specific (azure-cns, and later the CSI checks), while others are pure Kubernetes (coredns, kube-proxy). But I agree the underlying logic is Kubernetes-centric and portable.
Happy to move them. Should I move everything to lib/steps/k8s, or leave the Azure-specific checks (for example, azure-cns) here?
There was a problem hiding this comment.
Another option is to group your health check related lambdas into a new folder, since they are likely to be used together. It can be done in another pr, I'll approve this.
There was a problem hiding this comment.
Thanks! will move to new folder in next PR
3 participants
Functional validator that execs into a temporary busybox pod to verify the control-plane-to-node konnectivity tunnel works.