Refresh CI agent images and update auth methods for tests - #636
Open
DrewH-ms wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Refreshes CI environments, introduces optional service-connection authentication for tests, and modernizes test fixtures and dependencies.
Changes:
- Updates Azure Pipelines agents and authentication paths.
- Migrates .NET test modules to .NET 8/Windows Server 2022.
- Adjusts dependencies, test utilities, and packaging.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vsts_ci/win32/continuous-build-win32.yml |
Adds service-connection test execution. |
vsts_ci/linux/continuous-build-linux.yml |
Adds AAD execution and local registry startup. |
vsts_ci/.vsts-ci.yml |
Updates agents and job orchestration. |
tests/utility.py |
Adjusts registry initialization and error capture. |
tests/conftest.py |
Rewrites IoT CLI authentication arguments. |
tests/assets/test_solution_shared_lib/sample_module_2/sample_module_2.csproj |
Targets .NET 8. |
tests/assets/test_solution_shared_lib/sample_module_2/Dockerfile.windows-amd64 |
Updates Windows .NET images. |
tests/assets/test_solution_shared_lib/sample_module_2/Dockerfile.amd64.debug |
Updates Linux debug images. |
tests/assets/test_solution_shared_lib/sample_module_2/Dockerfile.amd64 |
Updates Linux runtime images. |
tests/assets/test_solution_shared_lib/modules/sample_module/sample_module.csproj |
Targets .NET 8. |
tests/assets/test_solution_shared_lib/modules/sample_module/Dockerfile.windows-amd64 |
Updates Windows .NET images. |
tests/assets/test_solution_shared_lib/modules/sample_module/Dockerfile.amd64.debug |
Updates Linux debug images. |
tests/assets/test_solution_shared_lib/modules/sample_module/Dockerfile.amd64 |
Updates Linux runtime images. |
setup.py |
Declares jsonschema. |
requirements.txt |
Updates runtime dependencies. |
requirements_dev.txt |
Removes unused Compose dependency. |
docker/tool/windows/Dockerfile.base |
Moves Nano Server image to MCR. |
azure-pipelines.yml |
Modernizes package installation and wheel builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI agent images (
windows-2019,ubuntu-20.04) have been retired, so every run fails at agent allocation:Azure.iotedgedevis a required check, so this blocks all merges.What
Refreshes the images and fixes what breaks on the newer agents. No product code changes.
windows-2022,ubuntu-22.04. Linux 3.6 leg dropped (not available on 22.04; Windows still covers 3.6). Linux now runs even if Windows fails.IOTHUB_AUTH_TYPE=login; unset behaves exactly as today.ltsc2022.dotnet/sdk:2.1has no Windows image for the 2022 agent kernel, so builds fail with an OS mismatch.jsonschema(imported bydeploymentmanifest.pybut never declared; unpinned because current releases need Python ≥ 3.10). Drop unusedmsrestazureanddocker-compose.nanoserverfrom MCR;azure-pipelines.ymlcleanup (unwired file, happy to drop it from this PR).Validation
All 7 legs green against this exact tree.
Two notes:
azureServiceConnectiondefault may need to match this project's connection name.CFS0011warnings are pre-existing and identical onmain.